Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move timeseries to vis_types folder #112228

Merged
merged 10 commits into from
Sep 21, 2021
Merged

Move timeseries to vis_types folder #112228

merged 10 commits into from
Sep 21, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 15, 2021 •
edited
Loading

Summary

Part of #107500

This is the fourth and final part of moving all the vis_type_* plugins to a new folder vis_types.

In this PR vis_type_timeseries is moved.

Changes in details are:

  • Moved the vis_type_timeseries to the vis_types folder.
  • Remove the vis_type_ from the folder name. From now on they will be timeseries. Important note: Only the folder names have changed and not the plugin ids.
  • All the relative paths have been updated
  • Updated all the kibana conf files (jest, tsconfig) to take under consideration the new paths

@elastic elastic deleted a comment from kibanamachine Sep 15, 2021
@stratoula stratoula added v7.16.0 v8.0.0 Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Sep 15, 2021
@stratoula stratoula marked this pull request as ready for review September 16, 2021 09:57
@stratoula stratoula requested review from a team as code owners September 16, 2021 09:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

flash1293
flash1293 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works as expected, LGTM

cjcenizal
cjcenizal approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the rollup plugin LGTM. Didn't test locally.

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

matschaffer
matschaffer approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 60500c2 into elastic:master Sep 21, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Sep 21, 2021
@stratoula
Move timeseries to vis_types folder (elastic#112228)
b84aa93 
* Move timeseries to vis_types folder

* Fix jest

* Fix types

* Fix more types

* Fix types

* fix jest tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
#	api_docs/data.json
#	api_docs/deprecations_by_plugin.mdx
@stratoula stratoula mentioned this pull request Sep 21, 2021
Merged
stratoula added a commit that referenced this pull request Sep 21, 2021
@stratoula
Move timeseries to vis_types folder (#112228) (#112646)
f3a4520 
* Move timeseries to vis_types folder

* Fix jest

* Fix types

* Fix more types

* Fix types

* fix jest tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
#	api_docs/data.json
#	api_docs/deprecations_by_plugin.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@flash1293 flash1293 flash1293 approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stratoula @elasticmachine @kibanamachine @matschaffer @cjcenizal @flash1293 @MichaelMarcialis @mbondyra