[Canvas] XY. Step 4. Update handlers.

[Kuznietsov]

Completes part of #110430, #101377.

Need to update the code, based on @ppisljar's instructions, written at this issue.

Step 4. XY. Update handlers. completed.

---

Further steps have been performed at this PR:

• added method updateVariables to the handlers at expressions plugin;
• added handling the change of handlers.variables at expressions plugin;
• uiState.set has been changed to updateVariables;
• replaced handlers.uiState with handlers.variables.

[Kuznietsov]

@elasticmachine merge upstream

[Kuznietsov]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 837c1eb
• Storybooks Preview
• Documentation Changes

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
expressionXy	-	79	+79
visTypeVislib	192	196	+4
visTypeXy	99	38	-61
total			+22

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2800	2802	+2
expressions	1626	1638	+12
expressionXy	-	453	+453
visTypeVislib	25	72	+47
visTypeXy	51	9	-42
visualizations	257	260	+3
total			+475

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
expressions	65	64	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
expressionXy	-	23.7KB	+23.7KB
visTypeVislib	376.8KB	376.8KB	-4.0B
visTypeXy	62.5KB	32.8KB	-29.7KB
visualizations	72.0KB	72.4KB	+387.0B
total			-5.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
visTypeVislib	1	8	+7
visTypeXy	5	1	-4
total			+3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	492.6KB	492.6KB	+27.0B
expressions	128.3KB	128.8KB	+544.0B
expressionXy	-	41.1KB	+41.1KB
visTypeVislib	19.6KB	20.6KB	+1016.0B
visTypeXy	40.9KB	23.2KB	-17.8KB
visualizations	32.9KB	33.0KB	+138.0B
total			+25.0KB

Unknown metric groups

API count

id	before	after	diff
data	3186	3188	+2
expressions	2072	2084	+12
expressionXy	-	468	+468
visTypeVislib	26	74	+48
visTypeXy	57	9	-48
visualizations	275	278	+3
total			+485

async chunk count

id	before	after	diff
expressionXy	-	1	+1
visTypeXy	3	2	-1
total			-0

References to deprecated APIs

id	before	after	diff
expressionXy	-	3	+3
visTypeXy	6	0	-6
total			-3

History

• 💚 Build #155666 succeeded 46f8b11
• 💚 Build #155633 succeeded 6094614
• 💚 Build #154886 succeeded 95a42e3
• 💚 Build #154858 succeeded cae0c88
• 💚 Build #154642 succeeded d635b53

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

[ppisljar]

seems this PR is also moving a lot of code. can we split this up in a few pieces so its easier to review ?

1. move all the files
2. isolate large changes in specific prs (like removing uiState)
3. do the rest in the last pr

[Kuznietsov]

seems this PR is also moving a lot of code. can we split this up in a few pieces so its easier to review ?

1. move all the files
2. isolate large changes in specific prs (like removing uiState)
3. do the rest in the last pr

Answered at the private conversation.