[kbn/io-ts] export and require importing individual functions #117958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
spalger
added
Team:APM - DEPRECATED
|
Pinging @elastic/apm-ui (Team:apm) |
|
Pinging @elastic/uptime (Team:uptime) |
spalger
added
the
release_note:skip
shahzad31
approved these changes
Nov 9, 2021
dgieselaar
approved these changes
Nov 9, 2021
spalger
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 9, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 9, 2021
spalger
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 9, 2021
Conflict between elastic#117958 and elastic#115145 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Nov 9, 2021
…117958) (#118074) * [kbn/io-ts] export and require importing individual functions (#117958) * [kbn/io-ts] fix direct import Conflict between #117958 and #115145 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make it "against the rules" to import from
target_nodeand other directories created by Bazel, and saw how we prevent importing all the code from@kbn/io-ts-utilsin the browser bundles I figured we should upgrade the way we do this a bit by setting up some importable targets in the@kbn/io-ts-utilspackage. There is now one import target for each module/function in io-ts:@kbn/io-ts-utils/deep_exact_rt@kbn/io-ts-utils/iso_to_epoch_rt@kbn/io-ts-utils/json_rt@kbn/io-ts-utils/merge_rt@kbn/io-ts-utils/non_empty_string_rt@kbn/io-ts-utils/parseable_types@kbn/io-ts-utils/props_to_schema@kbn/io-ts-utils/strict_keys_rt@kbn/io-ts-utils/to_boolean_rt@kbn/io-ts-utils/to_json_schema@kbn/io-ts-utils/to_number_rtIn addition to these import targets and updates to everything importing from
@kbn/io-ts-utils, this adds an ESLint rule that prevents importing from the root of the@kbn/io-ts-utilspackage and encourages used of the other modules instead. I implemented this across both theserverandpubliccode for consistency but I'd be happy to limit this eslint rule to just thepublicandcommoncode.