[eslint] automatically determine dev packages #127089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Mar 8, 2022
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 8, 2022
* [eslint] automatically determine dev packages * remove old eslint overrides that are not needed anymore (cherry picked from commit 1f514d7) # Conflicts: # .eslintrc.js # packages/kbn-type-summarizer/package.json
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 8, 2022
* [eslint] automatically determine dev packages * remove old eslint overrides that are not needed anymore (cherry picked from commit 1f514d7) # Conflicts: # .eslintrc.js # packages/kbn-optimizer/package.json # packages/kbn-plugin-generator/package.json # packages/kbn-type-summarizer/package.json
spalger
pushed a commit
that referenced
this pull request
Mar 8, 2022
spalger
pushed a commit
that referenced
this pull request
Mar 8, 2022
* [eslint] automatically determine dev packages (#127089) * [eslint] automatically determine dev packages * remove old eslint overrides that are not needed anymore (cherry picked from commit 1f514d7) # Conflicts: # .eslintrc.js # packages/kbn-optimizer/package.json # packages/kbn-plugin-generator/package.json # packages/kbn-type-summarizer/package.json * remove unnecessary eslint-override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added several devOnly packages since #80549, and several new dev packages have been added without the
kibana.devOnlyconfig. This is an effort to ensure that new packages use this property by tying it to dev-only eslint configs (especially related to using dev-dependencies. This isn't fool proof, but it's also one less list to update when you're creating a dev-only package.