[Enterprise Search] Enable unused var linting #127305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
backport:skip
scottybollinger
approved these changes
Mar 9, 2022
byronhulcher
approved these changes
Mar 9, 2022
cee-chen
approved these changes
Mar 9, 2022
GitHub suggested you as a reviewer! And I wanted someone outside the ent-search team to look at these changes in case I accidentally broke all of Kibana's linting or something haha |
|
Hahaha! That's actually more generous than my interpretation which was that you misclicked 😂 Rules in that blob only apply to files in the Enterprise Search plugin dir, so you're all good! |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enables linting unused variables in the Enterprise Search plugin. TypeScript currently breaks on all unused variables in the Enterprise Search plugin, but the (pre-commit) linter does not filter those out. That means it's common to accidentally miss an unused variable, wait for CI, and then have to add (multiple) commits to remove unused variables. Adding this as a linting rule will help avoid unnecessary CI runs and developer waiting times.