[Tracing] Add Elasticsearch instrumentation support to @elastic/kbn-es #138418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
added
release_note:skip
rudolf
approved these changes
Aug 10, 2022
spalger
reviewed
Aug 10, 2022
spalger
approved these changes
Aug 10, 2022
|
@elastic/kibana-core i can't get this PR stable after bringing it up to date. Are these known flakey tests? |
|
@Mpdreamz these tests seem to fail consistently: If these are also failing on @elastic/ml-ui It appears as if this PR is causing the test to fail because it's expecting a toast to appear. It's not obvious how these changes could cause that, could someone please help and take a look? |
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Updated the KibanaPageTemplate imports from the deprecated path.
* Removed file-type from package.json deps. Updated jimp to 0.16.1. Updated light & dark dashboard baseline screenshots to resolve failure due to resize degradation. * Replaced jimp with sharp and pixelmatch. Eliminates several deps, including file-type. Eliminates quality degradation from image resizing. * Fixed copy paste error, which lead to pass positives and errors. * Integrated updateBaselines flag into dashboards report testing. Fixed sharp resize to fit and not truncate the original image. * Removed accidental '.only' * Reverted area chart baseline. * Removed explicit declaration of sharp from package.json. * Adjusted dashboard screenshot size in attempt to eliminate layout scaling issues in CI testing. * Reverted dashboard screenshot size. Lowered tolerance in dashboard PNG reporting tests to force failure and collect CI screenshots. * Changed session save location for dashboard report images for better CI reporting. * Fixed small dashboard baseline screenshot with correct aspect ratio. * Updated 2 basline screenshots from CI. Lowered PNG match tolerance for dashboard screenshots to 1% for investigation of remaining screens. * Update of dashboard controls light mode baseline. Change of forced container width size in large dashboard layout test. * Updated dashboard controls dark mode baseline screenshot. Adjusted forced container width in large dashboard layout test for troubleshooting. * Lowering tolerance of PNG compare tests from 9% to 1% for troubleshooting. Replaced references to dedundant image service with existing, more adopted reporting service. Ideally, the PNG functions of the reporting service would be merged with the screenshot service as an image service. * Reverting tolerance of PNG compares to 0.09. Will create GH issues for specific teams to investigate. * Implemented PngService to provide an accessible single reference to PNG compare testing. Removed redundant implementations and references. * Updated service reference and call to png compare function left out of last commit. * Updated another missed PNG reference. * Removed superfluous parameter. * Update after bootstrap * Updated area chart baseline to match new render with panel filters. * Reverted limits in dashboard snapshot tests to original values. * Merge and rebuild. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* eui to v62.2.0 * i18n updates * EuiDescriptionListProps imports * eui to v62.2.1 * euitoast selector updates * more EuiDescriptionListProps imports * eui to v62.2.2 * snapshot updates * snapshot updates * toast selector updates * more snapshot updates * toast selector * TRIAL: timeout for loading spinner * do not assume a popover is closed before attempting to open it again * Revert "do not assume a popover is closed before attempting to open it again" This reverts commit 1b23165. * remove wait * eui to v62.2.3 * Fixx fleet unit test * eui to v62.2.4 * snapshot updates Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
* Don't truncate name or ID columns of watches table.
…amic content (elastic#139079) ## Summary Issue elastic#133186 ( as shown in below video) demonstrates couple of issues and this PR tries to fix those. https://user-images.githubusercontent.com/61860752/171141631-f633a223-af76-457d-bed2-6bd8ea418a0e.mp4 **ISSUE - 1** When in host details flyout, clicking on `show Top N`, the datagrid will flicker scrolling from right to left and then back to its original position. **Solution** : This issue was not reproducible so I am assuming this has been already resolved. ( See below video for more details) **ISSUE - 2** When in host details flyout, clicking on `show Top N`, the popup hides behind the bottom screen edge. This is because initially the popup was small but when `Show TopN` is clicked, the content of Popup is changed and popup becomes bigger in size forcing it to exceed out of the screen's real estate. **Solution** : This PR makes sure that, if hover actions Popup's content changes, Popup is re-positioned according to its new dimensions. Checkout below demonstration. https://user-images.githubusercontent.com/7485038/185380538-d8fb159a-d666-4be2-b3b0-161a21d1b9d6.mov
* Create Entity analytics page * Add Hosts risk dashboard to Entity analytics page * Add entity analytics to the old menu * Add entity analytics dashboard header * Add User risk dashboard to Entity analytics * Add entityAnalyticsDashoardEnabled feature flag * Move useEnableHostRiskFromUrl to a shared folder * Upgrade Entity analytics license to platinum * Add ml permission check for entity analytics dashboard old menu Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…astic#139345) * [ML] Improves messaging when an anomaly detection forecast errors * [ML] Edits following review
* ceses wip * cases flyout and modal * add theme provider * render embeddable component * update context menu * basic embeddable props description * update icons * set absolute time range * get permissions * update actions compatibility * add path to tsconfig * check permission for attach action * refactor * use fieldFormats for dates * functional tests * revert test subj * add generalCases * hide panel on action click * improve assertion * asserting case content * wip asserting swim lane content in Cases * unique id for embeddable, fix types * assert embeddable id and swim lane * resolve nit comments
…lastic#139377) * chore: remove `isQueryLoading` `isQueryLoading` is the same as `loading` so we can remove the extra state and effect * chore: document `isFirstUpdate` By reading the source code, it wasn't clear why `isFirstUpdate` is necessary. I added a comment that explains why it's there. Also moved the effect closer to its dependencies. * chore: remove `isFirstUpdate` in favor of showFullLoading `showFullLoading` is the non-effect equivalent of `isFirstUpdate` * chore: update comment * chore: remove unnecessary comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…astic#4666 (elastic#138378) * [Security Solution Platform] Allow customizable plugin page layout elastic#4666 * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* [TIP] cover every IoC type in display_name logic
* [TIP] avoid having displa name field mapping separately from value mappers
* [TIP] return {field,value} object from getDisplayName
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* [TIP] rename file from displa_value into displa_name
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…d rules (elastic#139427) * Adding migration * Removing timer * Adding functional test * Adding another test
…ealthStatus (elastic#139274) * Task health calculation never returns Error or Warning but logs the HealthStatus.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: boriskirov <boris.kirov@elastic.co>
…tic#139443) * Removing check to see if user is a cloud user before activating * Update x-pack/plugins/security/server/authentication/authenticator.test.ts Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
* Add tips and best practices to e2e tests readme * review suggestions
* move scss to styles folder * create empty packages * move code to packages * adapt usages * fix scss import path * update packages and readmes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
… circuit breaker (elastic#139501) * Adding service functions to alert factory * Fixing types * Fixing types * Small refactor * Adding functional test * Cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…lastic#138964) * query for data_stream datasets * support package collection mode * build index with metrics pattern * trailing comma * use getNewIndexPatterns everywhere * Include new stack_monitoring infix in healthcheck dataset name Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mat Schaffer <mat@elastic.co>
* update risk score to useSearchStrategy * remove console * fix types * unit tests * unit tests * fix cypress tests * cypress test * unit tests and cypress tests * fix type error * cypress * fix cypress * fix up * fix unit tests * fix import Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
⏳ Build in-progress, with failuresFailed CI Steps
Test Failures
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically sets up APM in any Elasticsearch instance that Kibana starts through
@elastic/kbn-es. This includes integration and e2e tests.It respects the same configuration as kibana and can be locally overridden in
kibana.dev.ymlas per #127892.It will bootstrap
secret_tokenandapi_keyin the local Elasticsearch secret store but as this appears to be broken for now these are passed directly to Elasticsearch as well.