Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] adds bulk edit rule actions #138900

Merged
merged 54 commits into from
Sep 6, 2022
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
2d2cf84
init bulk actions
vitaliidm Aug 15, 2022
e23d690
bulk edit rules
vitaliidm Aug 16, 2022
cc11341
[RAM] revisit later
vitaliidm Aug 16, 2022
e5cddaf
remove .only
vitaliidm Aug 16, 2022
eebaa87
fix eslint
vitaliidm Aug 16, 2022
d0f6b61
it's alive!
vitaliidm Aug 17, 2022
afab282
additonal tests
vitaliidm Aug 17, 2022
fdc0e9f
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 17, 2022
4e53111
rename actims
vitaliidm Aug 17, 2022
7cb4a07
fix tests
vitaliidm Aug 17, 2022
32a73a3
services.application.capabilities.actions.show;
vitaliidm Aug 17, 2022
85ead17
trying to fix bundle
vitaliidm Aug 17, 2022
3a8f591
immutability fix
vitaliidm Aug 17, 2022
f9e805a
types
vitaliidm Aug 18, 2022
f7517a8
increase bundle limit
vitaliidm Aug 18, 2022
5f893b6
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 18, 2022
1cce11f
remove services.application.capabilities.actions.show;
vitaliidm Aug 18, 2022
7f4f966
refactoring
vitaliidm Aug 18, 2022
075369a
fixes
vitaliidm Aug 18, 2022
2679a64
refactor
vitaliidm Aug 18, 2022
d6ccf0b
wording
vitaliidm Aug 22, 2022
13a7c94
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 22, 2022
070319e
update tests
vitaliidm Aug 22, 2022
f11fa66
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Aug 22, 2022
d8aa8db
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 24, 2022
3b37cb9
update message
vitaliidm Aug 25, 2022
4eb402a
fix i18n
vitaliidm Aug 25, 2022
0470b0c
updates
vitaliidm Aug 25, 2022
841a562
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 26, 2022
2cbc926
attempt to reduce bundle size
vitaliidm Aug 26, 2022
3ddf3a7
Merge branch 'detections/bulk-actions' of https://github.com/vitaliid…
vitaliidm Aug 26, 2022
34510ca
fix versino increment issue for prebuilt rules
vitaliidm Aug 26, 2022
1add5c0
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 30, 2022
7f73996
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 30, 2022
1c67a1c
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 31, 2022
0cd3934
fix issue with duplicated rule variables
vitaliidm Aug 31, 2022
a145e01
Merge branch 'main' into detections/bulk-actions
kibanamachine Aug 31, 2022
f11ae45
Merge branch 'main' into detections/bulk-actions
vitaliidm Aug 31, 2022
aa36d99
Update bulk_edit_rules.ts
vitaliidm Aug 31, 2022
905f358
move bulk actions enums to request schema
vitaliidm Sep 5, 2022
76aa2d6
CR: spelling
vitaliidm Sep 5, 2022
c1bfbac
CR: typings
vitaliidm Sep 5, 2022
6f82e91
CR: workaround feedback
vitaliidm Sep 5, 2022
ea9ca29
fix types for tests
vitaliidm Sep 5, 2022
c459748
Merge branch 'main' into detections/bulk-actions
vitaliidm Sep 5, 2022
5d48c02
Update x-pack/plugins/security_solution/public/detections/pages/detec…
vitaliidm Sep 6, 2022
d50a8b3
Update x-pack/plugins/security_solution/public/detections/pages/detec…
vitaliidm Sep 6, 2022
f5f216d
Update x-pack/plugins/security_solution/public/detections/pages/detec…
vitaliidm Sep 6, 2022
fc5d288
Update x-pack/plugins/security_solution/public/detections/pages/detec…
vitaliidm Sep 6, 2022
cc32c07
Update x-pack/plugins/security_solution/public/detections/pages/detec…
vitaliidm Sep 6, 2022
291b8bc
woridng
vitaliidm Sep 6, 2022
6f530b2
text updates
vitaliidm Sep 6, 2022
9c6dc77
back to ul
vitaliidm Sep 6, 2022
1a0df5a
Merge branch 'main' into detections/bulk-actions
vitaliidm Sep 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix eslint
vitaliidm committed Aug 16, 2022
commit eebaa87dc46053e337fb9a8203973a21970bcfbf
Original file line number Diff line number Diff line change
@@ -88,6 +88,6 @@ export const bulkEditActionToRulesClientOperation = (
];

default:
return assertUnreachable(action.type);
return assertUnreachable(action);
}
};
Original file line number Diff line number Diff line change
@@ -74,13 +74,13 @@ export const bulkEditRules = async ({
async (rule) => {
if (rule.muteAll && rulesAction.value.throttle !== NOTIFICATION_THROTTLE_NO_ACTIONS) {
await rulesClient.unmuteAll({ id: rule.id });
return readRules({ rulesClient, id: rule.id, ruleId: undefined });
return (await readRules({ rulesClient, id: rule.id, ruleId: undefined })) ?? rule;
} else if (
!rule.muteAll &&
rulesAction.value.throttle === NOTIFICATION_THROTTLE_NO_ACTIONS
) {
await rulesClient.muteAll({ id: rule.id });
return readRules({ rulesClient, id: rule.id, ruleId: undefined });
return (await readRules({ rulesClient, id: rule.id, ruleId: undefined })) ?? rule;
}

return rule;