-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating debugging docs: replacing apm.dev.js configuration references with kibana.dev.yml #152237
Updating debugging docs: replacing apm.dev.js configuration references with kibana.dev.yml #152237
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
Documentation preview: |
It looks like support for "apm.dev.js" was removed about 1 year ago in #127892, which updated This change looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving... to the degree that I'm allowed to approve. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text LGTM
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…s with kibana.dev.yml (elastic#152237) ## Summary Updating the Debugging Kibana documentation: 1. Adding Python as additional pre-requisite technology 2. Replacing apm.dev.js configuration with updated kibana.dev.yml approach Similar to recent discussion in issue elastic#79490, I've found that the `apm.dev.js` approach is no longer working. ### Checklist Delete any items that are not applicable to this PR. - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials ### Risk Matrix N/A ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 867c906)
…erences with kibana.dev.yml (#152237) (#152914) # Backport This will backport the following commits from `main` to `8.7`: - [Updating debugging docs: replacing apm.dev.js configuration references with kibana.dev.yml (#152237)](#152237) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carly Richmond","email":"74931905+carlyrichmond@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-03-08T14:43:34Z","message":"Updating debugging docs: replacing apm.dev.js configuration references with kibana.dev.yml (#152237)\n\n## Summary\r\n\r\nUpdating the Debugging Kibana documentation:\r\n\r\n1. Adding Python as additional pre-requisite technology\r\n2. Replacing apm.dev.js configuration with updated kibana.dev.yml\r\napproach\r\n\r\nSimilar to recent discussion in issue #79490, I've found that the\r\n`apm.dev.js` approach is no longer working.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### Risk Matrix\r\n\r\nN/A\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"867c906f6c872357b5e2e6335c5145d1f58e3730","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:fix","💝community","backport-v8.0.0","v8.7.0","v8.8.0","v8.7.1"],"number":152237,"url":"https://github.com/elastic/kibana/pull/152237","mergeCommit":{"message":"Updating debugging docs: replacing apm.dev.js configuration references with kibana.dev.yml (#152237)\n\n## Summary\r\n\r\nUpdating the Debugging Kibana documentation:\r\n\r\n1. Adding Python as additional pre-requisite technology\r\n2. Replacing apm.dev.js configuration with updated kibana.dev.yml\r\napproach\r\n\r\nSimilar to recent discussion in issue #79490, I've found that the\r\n`apm.dev.js` approach is no longer working.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### Risk Matrix\r\n\r\nN/A\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"867c906f6c872357b5e2e6335c5145d1f58e3730"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152237","number":152237,"mergeCommit":{"message":"Updating debugging docs: replacing apm.dev.js configuration references with kibana.dev.yml (#152237)\n\n## Summary\r\n\r\nUpdating the Debugging Kibana documentation:\r\n\r\n1. Adding Python as additional pre-requisite technology\r\n2. Replacing apm.dev.js configuration with updated kibana.dev.yml\r\napproach\r\n\r\nSimilar to recent discussion in issue #79490, I've found that the\r\n`apm.dev.js` approach is no longer working.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [X]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### Risk Matrix\r\n\r\nN/A\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"867c906f6c872357b5e2e6335c5145d1f58e3730"}}]}] BACKPORT--> Co-authored-by: Carly Richmond <74931905+carlyrichmond@users.noreply.github.com>
…s with kibana.dev.yml (elastic#152237) ## Summary Updating the Debugging Kibana documentation: 1. Adding Python as additional pre-requisite technology 2. Replacing apm.dev.js configuration with updated kibana.dev.yml approach Similar to recent discussion in issue elastic#79490, I've found that the `apm.dev.js` approach is no longer working. ### Checklist Delete any items that are not applicable to this PR. - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials ### Risk Matrix N/A ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Summary
Updating the Debugging Kibana documentation:
Similar to recent discussion in issue #79490, I've found that the
apm.dev.js
approach is no longer working.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
N/A
For maintainers