-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Experience App] Move UX public code out of apm #88645
Changes from all commits
803c86f
0d815c8
efa8291
0798b32
9e0dc21
393b4d2
2069e6a
be8be9a
4c042b1
0feb7a3
0c51752
7dfb8d6
9c481eb
a433df4
6b693de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,3 +121,4 @@ pageLoadAssetSize: | |
controls: 34788 | ||
expressionPie: 26338 | ||
sharedUX: 16225 | ||
ux: 20784 | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,3 +118,9 @@ export const uxLocalUIFilters = uxLocalUIFilterNames.reduce((acc, key) => { | |
}, | ||
}; | ||
}, {} as UxLocalUIFilterMap); | ||
|
||
export type UxUIFilters = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any chance we can move this entire file? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this one is tricky, it's being used in APM server. And UX plugin is using some stuff from APM. So for now relationship is one directional. UX app is dependant on APM. I kept it here for now , to not introduce circular dependency. Once routes are removed from APM, this will be gone auto. |
||
environment?: string; | ||
} & { | ||
[key in UxLocalUIFilterName]?: string[]; | ||
}; |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind updating the one for APM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm shouldn't this happen auto? i ran the script