Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint@7 #94347

Merged
merged 71 commits into from
Oct 2, 2021
Merged

Bump eslint@7 #94347

merged 71 commits into from
Oct 2, 2021

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Mar 10, 2021 •
edited
Loading

@patrykkopycinski patrykkopycinski self-assigned this Mar 10, 2021
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Mar 10, 2021
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

sabarasaba
sabarasaba approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack management changes LGTM 🚀 , didn't test locally

aleksmaus
aleksmaus approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tylersmalley tylersmalley requested review from parkiino and removed request for parkiino October 1, 2021 04:50
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into chore/eslint-7
a850733 
# Conflicts:
#	package.json
#	packages/kbn-pm/dist/index.js
#	src/dev/license_checker/config.ts
#	x-pack/plugins/actions/server/usage/actions_telemetry.ts
#	yarn.lock
@patrykkopycinski
fix types
170891d
@patrykkopycinski
lint
8c589c0
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1177 1178 +1
enterpriseSearch 1502 1503 +1
maps 838 839 +1
ml 1680 1681 +1
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +61.0B
enterpriseSearch 1.3MB 1.3MB +61.0B
maps 2.7MB 2.7MB +46.0B
ml 3.6MB 3.6MB +66.0B
securitySolution 4.3MB 4.3MB +8.0B
timelines 239.2KB 239.2KB -13.0B
total +229.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 36.5KB 36.5KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 2, 2021
@patrykkopycinski patrykkopycinski merged commit 4b89e14 into elastic:master Oct 2, 2021
@patrykkopycinski patrykkopycinski deleted the chore/eslint-7 branch October 2, 2021 15:38
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 94347

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 5, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 94347 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 94347 or prevent reminders by adding the backport:skip label.

@patrykkopycinski patrykkopycinski mentioned this pull request Oct 7, 2021
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 7, 2021
@patrykkopycinski
Bump eslint@7 (elastic#94347)
e3f8cf3 
# Conflicts:
#	packages/elastic-eslint-config-kibana/javascript.js
#	packages/kbn-eslint-plugin-eslint/rules/disallow_license_headers.test.js
#	packages/kbn-eslint-plugin-eslint/rules/no_restricted_paths.test.js
#	packages/kbn-eslint-plugin-eslint/rules/require_license_header.test.js
#	src/dev/eslint/lint_files.ts
#	x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/timeline/processor.tsx
#	yarn.lock
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2021
patrykkopycinski added a commit that referenced this pull request Oct 7, 2021
@patrykkopycinski @kibanamachine
Bump eslint@7 (#94347) (#114256)
9ef198a 
# Conflicts:
#	packages/elastic-eslint-config-kibana/javascript.js
#	packages/kbn-eslint-plugin-eslint/rules/disallow_license_headers.test.js
#	packages/kbn-eslint-plugin-eslint/rules/no_restricted_paths.test.js
#	packages/kbn-eslint-plugin-eslint/rules/require_license_header.test.js
#	src/dev/eslint/lint_files.ts
#	x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/timeline/processor.tsx
#	yarn.lock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@academo academo academo approved these changes

@kertal kertal kertal approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@aleksmaus aleksmaus aleksmaus approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@flash1293 flash1293 flash1293 approved these changes

@azasypkin azasypkin azasypkin approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

@lizozom lizozom lizozom approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@afharo afharo afharo approved these changes

@cnasikas cnasikas cnasikas approved these changes

@ymao1 ymao1 ymao1 approved these changes

@parkiino parkiino Awaiting requested review from parkiino

Assignees

@patrykkopycinski patrykkopycinski

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.