Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose CustomEvent constructor #1213

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 16, 2025

Ready for review Powered by Pull Request Badge

Summary

Fixes missing CustomEvent constructor; exposed by tests added in #1212.

@sgammon sgammon added bug Something isn't working lang:javascript Issues relating to JavaScript api:node Node API and stdlib labels Feb 16, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Feb 16, 2025
@sgammon sgammon self-assigned this Feb 16, 2025
@sgammon sgammon requested a review from a team February 16, 2025 03:08
@sgammon sgammon force-pushed the fix/custom-event-constructor branch from fc64ea5 to 2ef713f Compare February 16, 2025 03:15
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 93.39623% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (9bd1849) to head (c07ecc7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/gvm/internals/intrinsics/js/abort/AbortSignal.kt 90.76% 2 Missing and 4 partials ⚠️
...e/runtime/intrinsics/js/node/events/CustomEvent.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   52.89%   53.16%   +0.27%     
==========================================
  Files         425      429       +4     
  Lines       17142    17242     +100     
  Branches     3101     3125      +24     
==========================================
+ Hits         9067     9167     +100     
+ Misses       7062     7055       -7     
- Partials     1013     1020       +7     
Flag Coverage Δ
jvm 53.16% <93.39%> (+0.27%) ⬆️
lib 53.16% <93.39%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gvm/internals/intrinsics/js/AbstractJsIntrinsic.kt 80.00% <100.00%> (-20.00%) ⬇️
...m/internals/intrinsics/js/abort/AbortController.kt 100.00% <100.00%> (ø)
...m/internals/intrinsics/js/abort/AbortIntrinsics.kt 100.00% <100.00%> (ø)
.../kotlin/elide/runtime/gvm/internals/js/JsTimers.kt 60.99% <100.00%> (ø)
...vm/src/main/kotlin/elide/runtime/gvm/js/JsError.kt 32.60% <100.00%> (+2.17%) ⬆️
.../kotlin/elide/runtime/intrinsics/GuestIntrinsic.kt 28.57% <ø> (ø)
...lin/elide/runtime/intrinsics/js/AbortController.kt 100.00% <100.00%> (ø)
...tlin/elide/runtime/intrinsics/js/ReadableStream.kt 0.00% <ø> (ø)
...tlin/elide/runtime/intrinsics/js/node/EventsAPI.kt 100.00% <ø> (ø)
.../runtime/intrinsics/js/node/events/EventOptions.kt 29.03% <ø> (ø)
... and 7 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd1849...c07ecc7. Read the comment docs.

@sgammon sgammon force-pushed the feat/intrinsic-abort branch from 4345944 to ca39c98 Compare February 16, 2025 06:34
@sgammon sgammon force-pushed the fix/custom-event-constructor branch from 2ef713f to c07ecc7 Compare February 16, 2025 06:35
Base automatically changed from feat/intrinsic-abort to main February 16, 2025 07:34
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the fix/custom-event-constructor branch from c07ecc7 to c7cec07 Compare February 16, 2025 07:35
@sgammon sgammon merged commit a90a3ce into main Feb 16, 2025
4 of 16 checks passed
@sgammon sgammon deleted the fix/custom-event-constructor branch February 16, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:node Node API and stdlib bug Something isn't working lang:javascript Issues relating to JavaScript
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant