-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to Ember 2.x #10
Conversation
"ember-cli-test-loader": "0.2.2", | ||
"ember-qunit": "0.4.20", | ||
"ember-qunit-notifications": "0.1.0", | ||
"jquery": "^2.2.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed, gets included by ember now
@sivakumar-kailasam this looks awesome! This repo has been third or so on my list to deal with, but I hadn't gotten to it yet. I really appreciate all the work you've done here, it looks great. I left a few minor comments on the PR, but once we address those I think this is good to go. Thanks! |
@elwayman02 I was feeling _twitch_y 😉 about updating the version no too. I've addressed the feedback from the comments in the latest commit. Looking forward to raising further PRs so that I can finally start using it on my project 😄 |
I just headed to bed, but I'll look at this again in the morning and get it On Sun, Apr 10, 2016, 2:49 AM Sivakumar Kailasam notifications@github.com
|
Sure, wfm! Good night :) |
Hi @jimmay5469 @elwayman02, I was just going to start on a side project which needs Github issues and I didn't want to write adapters from scratch. I saw that you folks were trying to get this up to speed on 2.x libs. So I've ported them. It has passing tests and I'm planning to raise PRs to introduce issues and labels but the upgrade is my first step towards that. Let me know if there's anything more required in this PR. Cheers 😄
Implements #9