Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter tests #69

Merged
merged 5 commits into from
Dec 16, 2016
Merged

Adapter tests #69

merged 5 commits into from
Dec 16, 2016

Conversation

srvance
Copy link
Collaborator

@srvance srvance commented Dec 10, 2016

Added complete test coverage for all adapters based on their buildURL behavior. Also, minor correction to the README per ember-data source code assertion (see reference in commit comment) and added JetBrains files to .gitignore.

@srvance srvance mentioned this pull request Dec 10, 2016
this.get('store').findRecord('github-repository', 'jimmay5469/old-hash'); // get a repository
this.get('store').findRecord('github-branch', 'jimmay5469/old-hash/branches/master'); // get a branch
this.get('store').queryRecord('github-release', { repo: 'jimmay5469/old-hash', releaseId: 1 }) // get a specific release
this.get('store').query('github-release', { repo: 'jimmay5469/old-hash' }) // get a repo's releases
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@elwayman02
Copy link
Owner

LGTM

@elwayman02 elwayman02 merged commit ac6d091 into elwayman02:master Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants