Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding htmlUrl attribute to github-user #79

Merged
merged 3 commits into from
Feb 6, 2017
Merged

Adding htmlUrl attribute to github-user #79

merged 3 commits into from
Feb 6, 2017

Conversation

alexander-alvarez
Copy link
Contributor

No description provided.

@elwayman02
Copy link
Owner

Looks like the build is failing, can you investigate?

@alexander-alvarez
Copy link
Contributor Author

@elwayman02 might be related to deprecation warning for _lookupFactory in beta.
I moved beta into allowed failures.

It's complaining that since this is used: https://github.com/alexander-alvarez/ember-data-github/blob/patch-1/addon/adapters/github.js#L9 you need to add needs: ['service:github-session'] to all the adapter tests, but I don't know why, so I didn't want to just treat the symptoms if there's something underlying that's needs to be updated, which will remove the need to do this.

@elwayman02
Copy link
Owner

Merging for now, but we should probably just add the needs and not allow beta failures in the future. Don't want to block this PR, though.

@elwayman02 elwayman02 merged commit eb5fc9d into elwayman02:master Feb 6, 2017
@alexander-alvarez alexander-alvarez deleted the patch-1 branch February 6, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-alvarez @elwayman02 @Dhaulagiri