Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed runloop import deprecations in scroll-activity-service #474

Conversation

karl-sjogren
Copy link
Contributor

Ember 3.27 warns about a deprecation on importing run from @ember/runloop and then using run.begin and run.end. This PR just fixes the import to avoid the warning.

deprecate.js:136 DEPRECATION: Using `run.end` has been deprecated. Instead, import the value directly from @ember/runloop:
  import { end } from '@ember/runloop'; [deprecation id: deprecated-run-loop-and-computed-dot-access]

@elwayman02
Copy link
Owner

Thanks for catching and fixing this!

@elwayman02 elwayman02 merged commit 7bda275 into elwayman02:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants