Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ember-glimmer tests to run w/o jquery #16096

Merged
merged 8 commits into from
Jan 10, 2018

Conversation

ro0gr
Copy link
Contributor

@ro0gr ro0gr commented Jan 9, 2018

part of #16058

there are two notable changes:

  • fixed bug with event bubbling in the non-jquery event-dispatcher + action handler. This bug was detected by this test in no-jquery mode.
    The problem was that we stopped event bubbling once we found the first action handler caused action handler always returned false despite the bubbles argument.
  • an assertion for jquery availability was added to the ViewSupport.$(). The assertion message is the following: "You cannot access this.$() with jQuery disabled". I'm glad to improve wording here.

@ro0gr
Copy link
Contributor Author

ro0gr commented Jan 9, 2018

according to browserstack there is a remaining failing test on IE "triggers focus-in when focused". Looking into it

@rwjblue
Copy link
Member

rwjblue commented Jan 10, 2018

We should address that test, it only fails sporadically.

@rwjblue rwjblue merged commit 6afb824 into emberjs:master Jan 10, 2018
@rwjblue
Copy link
Member

rwjblue commented Jan 10, 2018

Thank you!

@ro0gr ro0gr deleted the ember-glimmer-no-jq branch January 10, 2018 13:32
@wycats wycats mentioned this pull request Jan 10, 2018
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants