Fix failing tests in link_to_test.js without jQuery
#16650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwebdev
changed the title
robwebdev
force-pushed
the
no-jquery
branch
2 times, most recently
from
3eb307e to
ab9342d
Compare
robwebdev
force-pushed
the
no-jquery
branch
2 times, most recently
from
d904f24 to
c8a7bfc
Compare
robwebdev
changed the title
link_to_test.js without jQuery
|
Should we then update Travis to run them without jquery? |
|
@krisselden If I were to remove this conditional then I would expect the build to fail on |
|
I'm closing this due to no longer being relevant. Sorry for letting it slide! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16058
This PR fixes the following tests:
The {{link-to}} helper - nested routes and link-to arguments: The {{link-to}} helper supports bubbles=falseThe {{link-to}} helper - nested routes and link-to arguments: The {{link-to}} helper supports bubbles=boundFalseyThingStatus
Ember.$ is not undefined)