Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about cpal drag and drop #1329

Merged
merged 2 commits into from
Mar 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eframe/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@ NOTE: [`egui_web`](../egui_web/CHANGELOG.md), [`egui-winit`](../egui-winit/CHANG


## Unreleased
* Change default for `NativeOptions::drag_and_drop_support` to `true` ([#1329](https://github.com/emilk/egui/pull/1329))


## 0.17.0 - 2022-02-22
13 changes: 8 additions & 5 deletions epi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -221,10 +221,13 @@ pub struct NativeOptions {
/// If false it will be difficult to move and resize the app.
pub decorated: bool,

/// On Windows: enable drag and drop support.
/// Default is `false` to avoid issues with crates such as [`cpal`](https://github.com/RustAudio/cpal) which
/// will hang when combined with drag-and-drop.
/// See <https://github.com/rust-windowing/winit/issues/1255>.
/// On Windows: enable drag and drop support. Drag and drop can
/// not be disabled on other platforms.
///
/// See [winit's documentation][drag_and_drop] for information on why you
/// might want to disable this on windows.
///
/// [drag_and_drop]: https://docs.rs/winit/latest/x86_64-pc-windows-msvc/winit/platform/windows/trait.WindowBuilderExtWindows.html#tymethod.with_drag_and_drop
pub drag_and_drop_support: bool,

/// The application icon, e.g. in the Windows task bar etc.
@@ -257,7 +260,7 @@ impl Default for NativeOptions {
always_on_top: false,
maximized: false,
decorated: true,
drag_and_drop_support: false,
drag_and_drop_support: true,
icon_data: None,
initial_window_pos: None,
initial_window_size: None,