Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu backend: do not try to render zero-sized surfaces #2313

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

teh-cmc
Copy link
Collaborator

@teh-cmc teh-cmc commented Nov 16, 2022

Prevent the wgpu renderer from trying to draw into zero-sized surfaces (a fairly common occurrence on the web), while still making sure to do the rest of the work for the current frame (e.g. submitting user-space command encoders).

@emilk emilk force-pushed the cmc/zero_sized_canvas branch from 2110220 to 5407c6b Compare November 16, 2022 16:55
@emilk emilk merged commit f701992 into emilk:master Nov 16, 2022
emilk added a commit that referenced this pull request Dec 2, 2022
* wgpu backend: do not try to render zero-sized surfaces

* reverse if

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
JohannesProgrammiert pushed a commit to JohannesProgrammiert/egui that referenced this pull request Jan 21, 2023
* wgpu backend: do not try to render zero-sized surfaces

* reverse if

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants