Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eframe: capture a screenshot using
Frame::request_screenshot
#2676eframe: capture a screenshot using
Frame::request_screenshot
#2676Changes from 47 commits
c533c46
318b1d5
dd6f898
447b68f
1f1e58f
6b7bf39
7e2232e
fb55318
387d81a
78650a2
2dc00e7
e1aa669
ae5d24e
a3b253b
94f3a84
9cf3b52
094f284
bf6e33a
52f886a
ff32cd8
06e6dc0
570e941
204a450
214146e
391629a
b333b56
73ea872
886fb7f
3245832
ecd4d96
554834c
632e0e5
3f34373
64a8452
c0b526a
23016b3
5fa9ced
f239e7a
4a1c38d
c154774
f437c12
00c63d4
78de848
516f8c6
4d638b1
c62aa2b
e3d937e
bf08887
08ea093
10e072c
19f7577
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the limitation for implementing this on web?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly my inexperience with wasm and any kind of web-dev. I took a stab at trying to port the screenshot example to wasm with the eframe-template though, and it seems like App::post_rendering is never called on the web?
From the backend perspectiv, 3 things are required;
I chose to use the Frame struct for delivering the flag and image data between the app and the backend, which was easy on native since everything could be handled inside the WinitApp::paint function. I didn't look too closely at the architecture of the webpainter yet, but as App::post_rendering is never called, there would be no way to deliver the image data back to the app.
If this is solved, I believe it would be possible to more or less copy-paste the actual screen capturing logic for wgpu and glow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to move up to the
# Unreleased
section