-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass HtmlCanvasElement
element directly in WebRunner::start
#4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
I think we should get this over the finish line. Let's not bother with backwards compatibility (i.e. handling either an id or an element). |
CI failure seems to be coming from main |
emilk
approved these changes
Jul 15, 2024
lucasmerlin
pushed a commit
to lucasmerlin/egui
that referenced
this pull request
Jul 30, 2024
9 tasks
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Sep 2, 2024
### What * Tracks egui `master` branch * Tracks rerun-io/egui_tiles#78 ~This changes the interface between HTML/JS and WASM from passing a canvas id, to passing the canvas element directly (emilk/egui#4780). This means the preview of this PR is broken, and merging this PR will likely break it for all subsequent PRs. @jprochazk do you have a good idea how we can fix this?~ ### TODO * [x] The `re_renderer` example needs a winit update * [x] Fix uses of deprecated functions. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested `pixi run rerun-web` * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7218?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7218?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7218) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
HtmlCanvasElement
element directly to WebRunner::start
HtmlCanvasElement
element directly to WebRunner::start
HtmlCanvasElement
element directly in WebRunner::start
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRunner::start
should accept canvas object #4746Migration guide
WebRunner::start
now accepts aweb_sys::HtmlCanvasElement
instead of its ID.If you are responsible for creating a canvas and assigning it an ID, you no longer need to assign it an ID, and can instead directly pass the canvas to
WebRunner
:If you already have a canvas in your HTML, you are no longer forced to assign it an ID. You can now use any method you prefer to retrieve it from the DOM.