Use --export-dynamic linker flag rather than --export-all when we want to export everything
#15413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
export_dynamic
branch
from
7f75391 to
48c150f
Compare
sbc100
force-pushed
the
export_dynamic
branch
2 times, most recently
from
64d413a to
e72a2f7
Compare
sbc100
force-pushed
the
export_dynamic
branch
from
e72a2f7 to
b85b766
Compare
sbc100
force-pushed
the
export_dynamic
branch
2 times, most recently
from
faab348 to
d55638c
Compare
sbc100
changed the title
--export-dynamic rather than --export-all when linking with MAIN_MODULE=1--export-dynamic linker flag rather than --export-all when we want to export everything
sbc100
force-pushed
the
test_data_exports
branch
from
735092d to
a9c7c80
Compare
sbc100
force-pushed
the
export_dynamic
branch
2 times, most recently
from
54ebb2a to
0276ff9
Compare
sbc100
force-pushed
the
export_dynamic
branch
2 times, most recently
from
a60c4c7 to
bd6af72
Compare
…AIN_MODULE=1 This means hidden symbols no longer get exported by default. The only way to export a hidden symbol when building with MAIN_MODULE, SIDE_MODULE or LINKABLE is to add it to the EXPORT_FUNCTIONS list. Also, update the `test_dlfcn_self` test which check the number of data exports to be precise. This means it will need updating anytime libc or some other core library adds or removes a data exports, but that seems like something we should be tracking here anyway.
sbc100
force-pushed
the
export_dynamic
branch
from
bd6af72 to
2bd3381
Compare
|
PTAL, I'd like to land this before #13006 since it hides the musl-internal hidden symbols. |
dschuff
approved these changes
Nov 3, 2021
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means hidden symbols no longer get exported by default. The
only way to export a hidden symbol when building with MAIN_MODULE,
SIDE_MODULE or LINKABLE is to add it to the EXPORT_FUNCTIONS list.
This should be code side win for anyone building with MAIN_MODULE=1
or LINKABLE, and some folks building with SIDE_MODULE=1.
The primary motivator for this change is the musl upgrade where there
are new hidden symbols being introduced but we don't want them
exported when building with MAIN_MODULE=1.