-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid API Calls being listed as warnings within System Log #1364
Comments
I changed this to WARN because other users were issuing commands and not knowing if there were being received and executed by EMS-ESP. There is no DEBUG anymore in EMS-ESP (unless compiled with DEBUG and only for developers, not for production). We can use TRACE but need to think how to do that. Also Michael's versions need to be merged back into dev soon. |
Sorry @proddy that's very nasty, since all api calls are in warnings. I do not see anything else then api-calls within systemlog. 2023-10-29 13:28:20.456 W 1330: [command] Calling command 'thermostat/values' |
i see, not good. I'll do a quick patch now. |
@proddy I see that you changed api call entries from warning to info. Is there any chance not to log the pure info api calls? system/info and boiler/values, thermostat/values etc. |
Set the log level to noticeor below to filter out info messages. You can do this by command. |
For me it's fine to filter ... I just thought that for most users using e.g. the ioBroker adapter, it might be good to just see change commands and not the ones used for polling actual values. |
yes, please try it out @tp1de and let us know if we need to change it |
For dev.5 is fine ... I just thought that avoiding too many entries in log would be better |
I agree, in Lines 340 to 348 in 6a221e8
Set the line 341 to LOG_DEBUG, these commands always give a json-response back But leave the commands with values (lines 344, 346) as LOG_INFO. |
I'll make the edit |
use DEBUG logging for commands with json output - #1364
API calls (e.g. from ioBroker) are listed within System Log as Warnings. (EMS-ESP Version 3.6.3-dev.4)
This should be avoided. Maybe as Debug entries, bit I believe that they are not necessary.
I had a firmware version some weeks ago from @MichaelDvP where these warnings were switched off.
The text was updated successfully, but these errors were encountered: