Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network connection and powerentities #1302

Merged
merged 45 commits into from
Sep 20, 2023
Merged

network connection and powerentities #1302

merged 45 commits into from
Sep 20, 2023

Conversation

MichaelDvP
Copy link
Contributor

@MichaelDvP MichaelDvP commented Sep 20, 2023

it's some more commits now. includes

  • powerentities, setting of 32bit values and max-limit to 32 bit, save to NVS
  • network, bssid and full scan
  • tr language additions, some web translationsstill missing
  • mqtt queue check
  • a mqtt connect change from bert melis i havn't merged before
  • changed handling of flag-svg in webpage due to package update
  • empty json for a/t-sensors, custom and scheduler, fix the api/device/commands for custom/scheduler
  • the missing dhw tags for some boiler values

@proddy proddy merged commit 96ff5ed into emsesp:dev Sep 20, 2023
@MichaelDvP MichaelDvP deleted the dev2 branch September 20, 2023 18:15
@proddy
Copy link
Contributor

proddy commented Sep 20, 2023

some of the changes are amazing @MichaelDvP - you clearly spent a lot of time on this PR

@proddy
Copy link
Contributor

proddy commented Sep 20, 2023

@MichaelDvP in boiler::process_UBAFactory() we're only reading nomPower at offset 4. Do we also need to add the min and max at offsets 5 and 6? I'm missing these.

image

@MichaelDvP
Copy link
Contributor Author

Do we need them as entities?
We can read them and set these values as min/max to burnMinPower/burnMaxPower.

@proddy
Copy link
Contributor

proddy commented Sep 21, 2023

my burnminpower and burnmaxpower are 0 and 50 respectively. Not 23 and 115, so I thought they were different entity values.

@MichaelDvP
Copy link
Contributor Author

my burnminpower and burnmaxpower are 0 and 50 respectively. Not 23 and 115, so I thought they were different entity values.

Yes, but i think you can't set burnMaxPower lower than 23 or higher than 115.

Btw there seems to be a bug in min/max settings in customizations if min is <0 like in hysteresis the max is always set avery high value. Have not found the cause yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants