Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show entity count in device list, remove type #1343

Merged
merged 5 commits into from
Oct 20, 2023
Merged

show entity count in device list, remove type #1343

merged 5 commits into from
Oct 20, 2023

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Oct 17, 2023

small change. what do you think? Showing the Type in a column on the right didn't make sense as most of the times it was hidden.

image

@proddy proddy requested a review from MichaelDvP October 17, 2023 20:57
@MichaelDvP
Copy link
Contributor

The entity count is good, but i would leave the type. Yes, it's hidden when showing the entities, but for new users it makes the types more clear when showing up frst time.

Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes, i've just merged and tested in my S3. Looks good.

@proddy proddy merged commit 1fded64 into emsesp:dev Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants