Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Norwegian translation #675

Closed
wants to merge 0 commits into from
Closed

Norwegian translation #675

wants to merge 0 commits into from

Conversation

Vikingn
Copy link
Contributor

@Vikingn Vikingn commented Oct 9, 2022

No description provided.

@proddy
Copy link
Contributor

proddy commented Oct 9, 2022

I will make a PR for this for only the NO changes since a lot has changed since the last update.

@proddy proddy closed this Oct 10, 2022
@proddy
Copy link
Contributor

proddy commented Oct 30, 2022

Hi @Vikingn - are you still planning to complete the Norwegian translations for the C++ entities? The file is locale_translations.h. Then we can move the 3.5.0 out of dev to main for our next major release. Let us know, thanks...

@Vikingn
Copy link
Contributor Author

Vikingn commented Oct 31, 2022

Hi Proddy ! Im working on the file. Im at line 483. Hope to be finished in 2-3 days.

@Vikingn
Copy link
Contributor Author

Vikingn commented Nov 2, 2022

How do we open it again ? I have the file...

@proddy proddy reopened this Nov 3, 2022
@Vikingn
Copy link
Contributor Author

Vikingn commented Nov 3, 2022

Hi Proddy !Tried to add the file locale_translations.h now. Does it look ok ?

@MichaelDvP
Copy link
Contributor

MichaelDvP commented Nov 4, 2022

@Vikingn I've seen your latest translation in https://github.com/Vikingn/EMS-ESP32/blob/dev/src/locale_translations.h
Due to parallel translations of pl it's a bit tricky to merge.
Should i add your translation together with pl to my dev and make a PR to your dev, than you can check the missing words in the latest version and make a new PR to this official version?

Oh, also your dev branch is ~100 commits back. better you fetch the latest dev first.
Here is a merged translation file (renamed to .txt to add it here), based on latest file with pl and your no-translations, some newer entities are missing.
(Edit: file with errors removed)

@proddy
Copy link
Contributor

proddy commented Nov 4, 2022

I was thining the same, I like Michael's approach

@MichaelDvP
Copy link
Contributor

Corrected file (some pl-entities contains commas, making trouble when converting to csv)
locale_translations.h.txt

@Vikingn Vikingn closed this Nov 4, 2022
@Vikingn
Copy link
Contributor Author

Vikingn commented Nov 4, 2022

The Norwegian is the last at right in each line after the swedish

@proddy
Copy link
Contributor

proddy commented Nov 4, 2022

we'll add it soon, I need to make some structural fixes first to the way we support the Polish language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants