Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to base translations, auto generate i18n #723

Merged
merged 7 commits into from
Nov 5, 2022
Merged

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Nov 5, 2022

No description provided.

@proddy proddy requested a review from MichaelDvP November 5, 2022 11:55
@proddy
Copy link
Contributor Author

proddy commented Nov 5, 2022

@MichaelDvP I took a similar approach and made the default translation polish so the fallback works and you don't need to use {{ }} in the non-polish translations. Seems to work.

Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with baseLocal pl other languages don't need the cases.
Please merge, than i'll update my PR to avoid merge conflicts.

@proddy proddy merged commit 6883dbb into emsesp:dev Nov 5, 2022
@proddy
Copy link
Contributor Author

proddy commented Nov 5, 2022

ok, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants