Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloatField will crash if the input is a number that is too big #8725

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

winmorre
Copy link
Contributor

Fix for #8716

@winmorre winmorre force-pushed the floatfield-crush/#8716 branch from bfc1638 to 9aee257 Compare October 21, 2022 08:57
@kevin-brown
Copy link
Member

This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats?

@winmorre
Copy link
Contributor Author

This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats?

I will add some unit test and also check if other fields have similar issue

@winmorre
Copy link
Contributor Author

This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats?

I will add some unit test and also check if other fields have similar issue

I have added a unit test for the floatfield overflow error.
Tried replicating this for both DecimalField and IntegerField but they worked fine with large data inputs.

@auvipy auvipy added the Bug label Nov 22, 2022
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor wording adjustments only

@auvipy auvipy merged commit 9e56f54 into encode:master Nov 22, 2022
@auvipy
Copy link
Member

auvipy commented Nov 22, 2022

thanks a lot both of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants