-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FloatField will crash if the input is a number that is too big #8725
Conversation
bfc1638
to
9aee257
Compare
This seems fairly reasonable. Is it possible to get an added unit test to cover this case? Also does this apply to other field types or is this unique to floats? |
I will add some unit test and also check if other fields have similar issue |
I have added a unit test for the floatfield overflow error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor wording adjustments only
thanks a lot both of you. |
Fix for #8716