Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8751 - Add support to Python 3.11 #8752

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

pauloxnet
Copy link
Member

refs #8751 - Add support to Python 3.11

Add support to Python 3.11 in tests, docs and classifier.

@foarsitter
Copy link

foarsitter commented Nov 9, 2022

As you probably already know and it might be out of scope for this pull reqeuest, but the requirement files in /requirements needs to be updated. In example: psycopg2 needs 2.9.5 to work with 3.11 according their changelog.

Locally, with updated dependencies, the tests are working fine for tox -e py311,django41

psycopg2-binary>=2.8.5,<2.10
wheel>=0.35.1,<0.39
twine>=3.2.0,<5.0
transifex-client

@auvipy
Copy link
Member

auvipy commented Nov 18, 2022

one is updated here #8767

@pauloxnet
Copy link
Member Author

one is updated here #8767

Thanks. I rebased and triggered another pipeline.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green now

@pauloxnet
Copy link
Member Author

all green now

I think we have only to wait that someone can merge this PR.

@tomchristie
Copy link
Member

Would you folks like me to merge this, or should we look at expanding the team so that we have other folks with merge permissions?

@pauloxnet
Copy link
Member Author

Would you folks like me to merge this, or should we look at expanding the team so that we have other folks with merge permissions?

I think it might be useful to have other people on the DRF team with merge permissions, if only to relieve you from for example merging less impactful PR like this.

@tomchristie
Copy link
Member

@pauloxnet Since this is your pull request, I've sent you an invite to @encode/django-rest-framework. Please don't feel obligated to accept - it's entirely your call.

@pauloxnet
Copy link
Member Author

@pauloxnet Since this is your pull request, I've sent you an invite to @encode/django-rest-framework. Please don't feel obligated to accept - it's entirely your call.

@tomchristie thanks, I've just accepted your invitation. I cannot promise you a big commitment on the project given the thousand other commitments but I will use my new permissions with caution.

@pauloxnet pauloxnet merged commit 2a2b092 into encode:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants