Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show memory usage in the Benchmark tests #2733

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muhammadahmadasifbhatti
Copy link
Contributor

@muhammadahmadasifbhatti muhammadahmadasifbhatti commented Mar 4, 2025

Closes: Show Memory usage in the benchmark tests

Description

We need to show the memory usage before and after each test. Since, we are currently using binaries of the engines and not the runtimes the process object won't be available. So, I am creating a new script in the package.json (test:node). This will run the bundles file using node.

Also, I will be writing another function named logMemoryUsage. It will check if the process object is available it will call the process.memoryUsage function.

Security Considerations

N/A

Scaling Considerations

N/A

Documentation Considerations

N/A

Testing Considerations

This PR in itself is addition to our new testing tool.

Compatibility Considerations

N/A

Upgrade Considerations

N/A

@muhammadahmadasifbhatti muhammadahmadasifbhatti marked this pull request as ready for review March 4, 2025 17:43
@naugtur
Copy link
Member

naugtur commented Mar 11, 2025

This is very unlikely to produce reliable measurements without interacting with GC. What is the goal here? Are you after the allocation spike or leak detection? Are you concerned about memory consumption of a specific usecase?

See

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants