resolves #111 preserve comment on enum members #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
force-pushed
the
issue-111-enum-comment
branch
from
4de43dd to
f4b1ee0
Compare
ggrossetie
commented
Jan 7, 2020
| { | ||
| const enumProperties = (doclet['properties'] as Array<IDocletBase>); | ||
| // @ts-ignore | ||
| const enumMembers = node['members']; |
There was a problem hiding this comment.
Not sure if there's a safe way to call members on ts.Node. I tried to cast it using as but it's not working.
Without the @ts-ignore directive, I get the following warning/error:
TS7017: Element implicitly has an 'any' type because type 'Node' has no index signature.
f4b1ee0 to
47f4449
Compare
ggrossetie
force-pushed
the
issue-111-enum-comment
branch
from
47f4449 to
d9e41fe
Compare
|
Closing this in favor of #116. Let me know if there are any changes there you think should be made before I merge it in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #111