Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable console logging for tests #124

Merged
merged 4 commits into from
Apr 7, 2020

Conversation

aidinabedi
Copy link
Contributor

@aidinabedi aidinabedi commented Apr 6, 2020

Currently, all logging in the library is silently discarded when running the tests. Which makes detecting issues and debugging unnecessarily a lot harder. The PR fixes this by making the following changes:

  1. When tests spawn a jsdoc child process (via jsdoc-api), configure spawn so that stdio is inherited.
  2. Because jsdoc-api doesn't provide a way to configure the spawn in the main API, use lower-level APIs. This is what the new file jsdoc-api.js does (and jsdoc-api.d.ts provides typings for).
  3. Remove the old jsdoc-api.d.ts, which is no longer needed.

As a bonus, I also fixed the following warning that otherwise wouldn't show up in Namespace Checks:

[TSD-JSDoc] Unable to resolve type for an unnamed item, this is likely due to invalid JSDoc.
Often this is caused by invalid JSDoc on a parameter. Defaulting to `any`.

@englercj englercj merged commit bbf7c03 into englercj:master Apr 7, 2020
@aidinabedi aidinabedi deleted the feature/enable-tests-log branch April 8, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants