-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send conversion method suggestions #7857
Send conversion method suggestions #7857
Conversation
Thank you @4e6, I think the information sent shall be sufficient for the IDE to find out all "roles" a "value at hand" can play (be converted to):
The IDE can search for all methods named
...where the
...and include the methods of |
returnType = "Unnamed.Test.MyType", | ||
selfType = "Number", | ||
selfType = "Standard.Base.Data.Numbers.Number", | ||
returnType = "Unnamed.Test.Foo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that seems correct. selfType
is now FQN. returnType
is the type we convert to.
Suggestion | ||
.Argument("opt", "Unnamed.Test.MyMaybe", false, false, None) | ||
.Argument( | ||
"other", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional arguments are available as well. Good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Pull Request Description
close #7320
Changelog:
Important Notes
For example, the
Day_Of_Week_From
conversion is sent asChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.