Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow secrets in AWS_Credential #8774

Merged
merged 17 commits into from
Jan 19, 2024
Merged

Allow secrets in AWS_Credential #8774

merged 17 commits into from
Jan 19, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 16, 2024
@radeusgd radeusgd self-assigned this Jan 16, 2024
@radeusgd radeusgd force-pushed the wip/radeusgd/8722-secrets-in-aws-cred branch from 5613921 to b38e721 Compare January 16, 2024 11:20
@radeusgd radeusgd marked this pull request as ready for review January 16, 2024 11:53
@radeusgd radeusgd linked an issue Jan 16, 2024 that may be closed by this pull request
Ability to create an AWS_Credential with support for Enso Secrets #8722
Closed
@radeusgd radeusgd force-pushed the wip/radeusgd/8722-secrets-in-aws-cred branch 3 times, most recently from 33389e5 to 01f1443 Compare January 16, 2024 13:27
@radeusgd radeusgd force-pushed the wip/radeusgd/8722-secrets-in-aws-cred branch 3 times, most recently from 5abfa9f to 850a054 Compare January 18, 2024 09:14
Base automatically changed from wip/radeusgd/8739-secrets-in-auth-headers to develop January 18, 2024 12:49
@radeusgd radeusgd force-pushed the wip/radeusgd/8722-secrets-in-aws-cred branch from 850a054 to d018d38 Compare January 18, 2024 13:09
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jan 18, 2024
@radeusgd
increase timeouts
1121ae1 
This is just a band-aid fix, we probably need to do something about the constant failures and heavy runner load, see: #8806
@radeusgd radeusgd requested a review from 4e6 as a code owner January 19, 2024 11:41
@radeusgd radeusgd force-pushed the wip/radeusgd/8722-secrets-in-aws-cred branch from bfadb91 to 824a69a Compare January 19, 2024 12:19
hubertp
hubertp approved these changes Jan 19, 2024
View reviewed changes
lib/scala/json-rpc-server-test/src/main/scala/org/enso/jsonrpc/test/JsonRpcServerTestKit.scala
@@ -153,7 +153,7 @@ abstract class JsonRpcServerTestKit
}

def expectSomeJson(
timeout: FiniteDuration = 5.seconds.dilated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's revert in #8806 fix

@mergify mergify bot merged commit 368e486 into develop Jan 19, 2024
23 of 25 checks passed
@mergify mergify bot deleted the wip/radeusgd/8722-secrets-in-aws-cred branch January 19, 2024 19:00
@enso-bot enso-bot bot mentioned this pull request Jan 22, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@radeusgd radeusgd

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to create an AWS_Credential with support for Enso Secrets
4 participants
@radeusgd @hubertp @jdunkerley @GregoryTravis