dns: allow using the getaddrinfo-based system DNS resolver
#2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-Apple platforms like Linux and Android. Updated the Kotlin, Java & C++ builders. Added here: envoyproxy/envoy#22080 Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
changed the title
getaddr-based system DNS resolver
Augustyniak
reviewed
Jul 14, 2022
| dnsResolverConfig = String.format( | ||
| "{\"@type\":\"type.googleapis.com/envoy.extensions.network.dns_resolver.cares.v3.CaresDnsResolverConfig\",\"resolvers\":%s,\"use_resolvers_as_fallback\": %s, \"filter_unroutable_families\": %s}", | ||
| dnsFallbackNameserversAsString, !dnsFallbackNameservers.isEmpty() ? "true" : "false", | ||
| dnsFilterUnroutableFamilies ? "true" : "false"); |
There was a problem hiding this comment.
no action needed - just want to point out that for our new resolver dnsFilterUnroutableFamilies is effectively always equal to true as I pointed out in https://github.com/envoyproxy/envoy/pull/22080/files#r919203157.
Just something for future us - we will need to clean up all of the DNS flags/options that we expose.
jpsim
changed the title
getaddr-based system DNS resolvergetaddrinfo-based system DNS resolver
Co-authored-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com> Signed-off-by: JP Simard <jp@jpsim.com>
Co-authored-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
commented
Jul 14, 2022
library/java/io/envoyproxy/envoymobile/engine/EnvoyConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JP Simard <jp@jpsim.com>
They aren't configurable with the getaddrinfo-based resolver. Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
previously approved these changes
Jul 14, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
approved these changes
Jul 14, 2022
jpsim
added a commit
that referenced
this pull request
Jul 18, 2022
* main: tools: fix source mapping (#2429) Update Envoy (#2427) tools: add arm64 debug run configuration (#2424) Revert "docs: use sphinx githubpages extension (#2418)" (#2425) Remove Tulsi configuration & docs (#2421) Fix isCleartextTrafficPermitted (#2420) Squelch two JNI build warnings (#2426) dns: allow using the `getaddrinfo`-based system DNS resolver (#2419) docs: use sphinx githubpages extension (#2418) Update Envoy (#2417) Remove rules_cc uses Bump Lyft Support Rotation (#2414) iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415) Update Envoy (#2413) engine: remove outdated comment about `registerFactories()` (#2412) api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410) Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-Apple platforms like Linux and Android.
Updated the Kotlin, Java & C++ builders.
Added here: envoyproxy/envoy#22080
Risk Level: Low to moderate, off by default but I had to refactor some stuff.
Testing: Added.
Docs Changes: Documentation comments.
Release Notes: Added.
Signed-off-by: JP Simard jp@jpsim.com