-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: don't run copy-current-release-docs
as part of gen-check
#5445
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5445 +/- ##
==========================================
- Coverage 65.26% 65.25% -0.01%
==========================================
Files 213 213
Lines 33915 33915
==========================================
- Hits 22133 22130 -3
- Misses 10448 10450 +2
- Partials 1334 1335 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -1,15 +0,0 @@ | |||
+++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these removed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we didn't need these, make docs
will copy them when release doc site.
remove these will reduce the confuse for a beginner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will the Hugo "Edit this Page" feature still work ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it won't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall that ths is added by @zhaohuabing, for accessing default path as the latest release version. Need a review from @zhaohuabing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could point the "Edit this Page" links in the docs to the latest released version (e.g. v1.3), then it would work.
No description provided.