Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: don't run copy-current-release-docs as part of gen-check #5445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zirain
Copy link
Member

@zirain zirain commented Mar 9, 2025

No description provided.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner March 9, 2025 12:55
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (8394b1e) to head (b610916).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5445      +/-   ##
==========================================
- Coverage   65.26%   65.25%   -0.01%     
==========================================
  Files         213      213              
  Lines       33915    33915              
==========================================
- Hits        22133    22130       -3     
- Misses      10448    10450       +2     
- Partials     1334     1335       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -1,15 +0,0 @@
+++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these removed ?

Copy link
Member Author

@zirain zirain Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't need these, make docs will copy them when release doc site.
remove these will reduce the confuse for a beginner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the Hugo "Edit this Page" feature still work ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it won't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall that ths is added by @zhaohuabing, for accessing default path as the latest release version. Need a review from @zhaohuabing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could point the "Edit this Page" links in the docs to the latest released version (e.g. v1.3), then it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants