ISSUE-457: Multiple bug fixes and improvements for Content Search API (Plain Text) #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels like nitrogliceryn in your coffee @alliomeria . But allows us to use the caching mechanic Drupal would normally expose to any request from the outside even if the call is happening chained from the Content Search controller into the Exposed endpoint one.
Also chunks and counts/merges annotations. More failsafes. So many checks... @alliomeria this is better but still not optimal. I want to - Generate a Stale cache (file) so if the system requires to rebuild an expensive cache the response will be returned from the stale (previous) cache until the new one is re-generated. That requires TONS + 200grams of extra code - I want to cache the JMESPATH evaluations. There is NO need to get them everytime. Like no need. We can "calculate" which images/files/vtts point to which canvases once per cached manifest.
DiegoPino
added
bug
This is hard. But without creating a new cache so far my best choice. Previously this was generating an infinite loop bc of accumulated requests. So far this works better but i have to double double check
|
@alliomeria I will merge. More might come by Wednesday but this fixes several issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #457
I will make this 1.4.0 (since release happened but we are always allowed to make fixes until we start 1.5.0 branches & publish the release itself as a ZIP).
This is not ready yet. I want to check what is happening with the SBF_ Aggregator processor and why it is triggered when the type of query has full processing ... Drupal gosh.