Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libraries: fixed no "OK" ACK for Signed Update #6351

Merged
merged 2 commits into from
Aug 1, 2019
Merged

libraries: fixed no "OK" ACK for Signed Update #6351

merged 2 commits into from
Aug 1, 2019

Conversation

thangktran
Copy link
Contributor

Fixes: #6348

@earlephilhower earlephilhower requested a review from d-a-v July 27, 2019 07:20
@earlephilhower
Copy link
Collaborator

In the worst case, I think we can use this. But let's see if @d-a-v has any better ideas for making sure the packets are all gone before reboot than a timeout.

@d-a-v d-a-v mentioned this pull request Aug 1, 2019
Open
d-a-v
d-a-v approved these changes Aug 1, 2019
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
#6369 will try to improve this fix

@d-a-v d-a-v merged commit f78ab66 into esp8266:master Aug 1, 2019
@thangktran thangktran deleted the thangktran/bugfix/No_OK_ACK_after_uploading_Signed_Update branch August 1, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

espota.py does not receive OK when Signed Update is used
3 participants
@thangktran @earlephilhower @d-a-v