Laskukorjausten kohdistuminen tiettyyn kuukauteen #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akheron
commented
Sep 27, 2024
•
akheron
commented
- Laskuille siirretyt korjaukset kohdistuvat tiettyyn kuukauteen
- Kaikki vanhatkin korjaukset näytetään käyttöliittymässä
akheron
commented
Sep 27, 2024
service/src/main/kotlin/fi/espoo/evaka/invoicing/service/InvoiceGenerator.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/fi/espoo/evaka/invoicing/service/InvoiceCorrection.kt
Outdated
Show resolved
Hide resolved
akheron
force-pushed
the
invoice-correction-target
branch
2 times, most recently
from
93a76bc to
2b149b0
Compare
akheron
force-pushed
the
invoice-correction-target
branch
3 times, most recently
from
2d3b752 to
0adffa7
Compare
Joosakur
reviewed
Oct 1, 2024
service/src/main/kotlin/fi/espoo/evaka/invoicing/service/InvoiceCorrectionQueries.kt
Outdated
Show resolved
Hide resolved
akheron
force-pushed
the
invoice-correction-target
branch
3 times, most recently
from
f032a97 to
869da0e
Compare
Joosakur
force-pushed
the
invoice-correction-target
branch
2 times, most recently
from
5fd3768 to
fa076b2
Compare
akheron
force-pushed
the
invoice-correction-target
branch
5 times, most recently
from
802d95c to
0353b8d
Compare
Joosakur
reviewed
Oct 5, 2024
service/src/main/resources/db/migration/V444__invoice_correction_target.sql
Outdated
Show resolved
Hide resolved
Joosakur
reviewed
Oct 5, 2024
service/src/main/kotlin/fi/espoo/evaka/invoicing/service/InvoiceCorrectionQueries.kt
Outdated
Show resolved
Hide resolved
akheron
force-pushed
the
invoice-correction-target
branch
4 times, most recently
from
4b205df to
bb25f59
Compare
akheron
force-pushed
the
invoice-correction-target
branch
4 times, most recently
from
6ae59a3 to
a83cc86
Compare
akheron
force-pushed
the
invoice-correction-target
branch
3 times, most recently
from
f32370f to
77b3747
Compare
Creating is deliberately broken, and editing is not possible yet.
Also, be more conservative when deleting invoice correction rows to avoid accidential deletions.
Use the default of "current month + 1" if there are no sent invoices in the database.
akheron
force-pushed
the
invoice-correction-target
branch
from
77b3747 to
7866859
Compare
Delete corrections that have been affected by some bug that made them be applied too many times. Disregard invoice drafts when splitting invoice corrections to months.
akheron
force-pushed
the
invoice-correction-target
branch
from
4f83b1b to
b942a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.