Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korjauksia ja parannuksia sähköpostinotifikaatioiden blokkaukseen #5835

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Korjauksia ja parannuksia sähköpostinotifikaatioiden blokkaukseen #5835

merged 3 commits into from
Oct 29, 2024

Conversation

Joosakur
Copy link
Contributor

@Joosakur Joosakur commented Oct 17, 2024 •
edited
Loading

  • migratoitu kantaan enabled_email_types text[] tilalle disabled_email_types email_message_type[] not null
  • yhdistetty osa tyypeistä keskenään, jotta kuntalaiselle ei tule liian pitkää listaa valintoja
  • ei-kunnalliset (johtajan lähettämät) tiedotteet lasketaan jatkossa kuuluvan henkilökunnan lähettämiin viesteihin

@Joosakur Joosakur added the enhancement Uusi toiminnallisuus tai parannus label Oct 17, 2024
@Joosakur Joosakur force-pushed the email-notification-fixes branch 3 times, most recently from dc228f4 to 969ed06 Compare October 21, 2024 13:18
@Joosakur Joosakur marked this pull request as ready for review October 21, 2024 13:42
terolaakso
terolaakso approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@terolaakso terolaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as the missing translations are provided, and the next step of removing the enabled_email_types column is handled.

@Joosakur Joosakur force-pushed the email-notification-fixes branch from 9401551 to bb29938 Compare October 29, 2024 07:58
@Joosakur Joosakur force-pushed the email-notification-fixes branch from bb29938 to 8784a60 Compare October 29, 2024 08:00
@Joosakur Joosakur mentioned this pull request Oct 29, 2024
Merged
@Joosakur Joosakur merged commit 915728f into master Oct 29, 2024
28 checks passed
@Joosakur Joosakur deleted the email-notification-fixes branch October 29, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terolaakso terolaakso terolaakso approved these changes

Assignees
No one assigned
Labels
enhancement Uusi toiminnallisuus tai parannus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joosakur @terolaakso