Käsitellään edellisten Varda-lähdejärjestelmien maksutiedot oikein #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akheron
changed the title
If an entry from old system needs to be modified by eVaka, it's either set to end the day before a new entry in eVaka data starts, or deleted if it would be set to end before a *minimum valid end date* (which is mandated by Varda validation rules). This commit fixes fee data to have a separate *minimum valid end date*, because that's how it is in Varda validation rules.
akheron
force-pushed
the
varda-minimum-valid-fee-end-date
branch
from
c3bb657 to
c72fed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Varda määrää varhaisimman sallitun päättymispäivän Vardaan lähetettävälle datalle. Yleensä se on 1.1.2019, mutta maksutietojen osalta 1.9.2019. eVaka asettaa edellisen lähdejärjestelmän lähettämälle datalle päättymispäivän, mikäli se menisi päällekkäin eVakassa olevan datan kanssa. Jos asetettava päättymispäivä olisi pienempi kuin varhaisin Vardan sallima päättymispäivä, eVaka sen sijaan poistaa edellisen lähdejärjestelmän datan.
Tämä prosessi ei toiminut oikein maksutietojen osalta, sillä eVaka ei aiemmin ottanut huomioon maksutietojen erillistä varhaisinta sallittua päättymispäivää. Nyt ottaa.