Yksikön johtajien käyttöoikeus ja yksikön mukaan suodatus varhaiskasvatuksessa aloittavien raportille #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmkrepo
force-pushed
the
remove-ssn-from-ece-arrivals-departures-reports
branch
3 times, most recently
from
fd3eb6a to
fb98275
Compare
Joosakur
approved these changes
Nov 7, 2024
Comment on lines
185
to
187
| const rows = orderBy(rawResult.filter(displayFilter), sort.columns, [ | ||
| sort.direction === 'ASC' ? 'asc' : 'desc' | ||
| ]) |
There was a problem hiding this comment.
this could be memoized with something like
const sortedResult = useMemo(() =>
result.map(rawResult => orderBy(rawResult.filter(displayFilter), sort.columns, [
sort.direction === 'ASC' ? 'asc' : 'desc'
])),
|result, displayFilter, sort]
)
return (
<>
{renderResult(sortedResult, (rows) => {
but maybe it's not too heavy anyway
There was a problem hiding this comment.
Moved sorting under memo, but unfiltered data is necessary for filter selection population so filtering needs to be handled separately under result rendering.
Wnt
added
enhancement
tmkrepo
force-pushed
the
remove-ssn-from-ece-arrivals-departures-reports
branch
from
fb98275 to
bf625a0
Compare
tmkrepo
force-pushed
the
remove-ssn-from-ece-arrivals-departures-reports
branch
from
bf625a0 to
c41a32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raportti näyttää nyt aloittavat lapset valitulle kuukaudelle myös yksikön johtajille. Raportille lisätty yksikön nimi, yksikön mukaan suodatus ja sarakkeiden mukaan järjestäminen.