Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kevennetään SAML-virhelokitusta #6008

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Kevennetään SAML-virhelokitusta #6008

merged 5 commits into from
Nov 25, 2024

Conversation

Gekkio
Copy link
Contributor

@Gekkio Gekkio commented Nov 20, 2024

No description provided.

We use Node 20.18 which has full ES2023 support
- 'InResponseTo is not valid' is never logged, even if we are not
  currenty logged in
- if we can find a SAML error description (= IDP returned a SAML error),
  log the error only to the audit log
- ignore/silence same error scenarios in the logout callback too
@Gekkio Gekkio added the tech Tekninen muutos, esim. refaktorointi label Nov 20, 2024
@Gekkio Gekkio marked this pull request as ready for review November 20, 2024 13:40
@Gekkio Gekkio merged commit 27849e5 into master Nov 25, 2024
31 checks passed
@Gekkio Gekkio deleted the better-saml-error-logging branch November 25, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech Tekninen muutos, esim. refaktorointi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants