Generoidaan vahvat ID-tyypit fronttiin, osa 1 #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akheron
commented
Dec 3, 2024
akheron
commented
Dec 3, 2024
service/codegen/src/main/kotlin/evaka/codegen/api/TsRepresentation.kt
Outdated
Show resolved
Hide resolved
akheron
commented
Dec 3, 2024
service/codegen/src/main/kotlin/evaka/codegen/api/TsCodeGenerator.kt
Outdated
Show resolved
Hide resolved
akheron
force-pushed
the
codegen-partials
branch
from
6735b97 to
5b04299
Compare
akheron
changed the title
akheron
force-pushed
the
codegen-ids
branch
6 times, most recently
from
496aa30 to
e9580ea
Compare
They're all just aliases to `string` for now.
Before this change, `BackupCareId`s were coerced to `PlacementId`s in service, and their fields were also mixed in a way that allows impossible combinations. Fix this by introducing separate types for missing group placements and missing backup group placements.
Gekkio
approved these changes
Dec 11, 2024
akheron
changed the title
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generoidaan kaikki ID-tyypit fronttiin. Transitiovaiheessa osa tyypeistä generoidaan
string-aliaksiksi, ja osa vahvoiksi tyypeiksi.Vahva tyypitys perustuu "branded types" -tekniikkaan, jolloin ajon aikaisesti käsitellään stringejä, mutta tyyppitasolla eri ID:t eivät ole yhteensopivia keskenään.
ID-tyyppejä on yhteensä 82 ja tämän PR:n jälkeen niistä 32 (~39 %) on vahvasti tyypitettyjä ja loput string-aliaksia.