-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Järjestellään apigw:n polut ja middlewaret uusiksi #6085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5592ecb
to
3f608e6
Compare
2342285
to
d5921b9
Compare
e33a750
to
4e471d0
Compare
805d2ff
to
bb5f046
Compare
81b35c3
to
36c687b
Compare
Gekkio
commented
Dec 10, 2024
Gekkio
commented
Dec 10, 2024
18ef9ca
to
38a3e60
Compare
akheron
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ekaa kertaa ikinä tuntuu siltä että tajuaa vähän miten apigw toimii 😂 🏅
We no longer have a top-level proxy so this is not necessary
express-session parses its own cookies, and we don't need to parse anything else
Now that every route is in one place, we can once again simplify middlewares based on the URL prefix
This is needed because playwright images used in CI e2e tests are built from master, so the path change doesn't take effect until it's merged to master
4921b1b
to
01ae875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanha enduser/internal -jako aiheuttaa kitkaa tulevan palvelutuottajan suomi.fi-kirjautumisen kanssa, joten siirrytään pikku hiljaa pois siitä.
Uudet polut (tuettu mutta ei vielä käytössä client-puolella!):