Titania raportin jatkokehitys #6140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix incoming Titania dataset validation - add possibility to remove individual rows from Titania error report
msavolainen-gofore
force-pushed
the
titania-report-enhancement
branch
from
5a535e8 to
4560059
Compare
Wnt
reviewed
Dec 18, 2024
service/src/main/kotlin/fi/espoo/evaka/reports/TitaniaErrorsReport.kt
Outdated
Show resolved
Hide resolved
Wnt
reviewed
Dec 18, 2024
service/src/main/kotlin/fi/espoo/evaka/reports/TitaniaErrorsReport.kt
Outdated
Show resolved
Hide resolved
Wnt
reviewed
Dec 18, 2024
| tx, | ||
| user, | ||
| clock, | ||
| Action.Global.READ_TITANIA_ERRORS, |
There was a problem hiding this comment.
Pitäisikö tässä olla myös erillinen ACL sääntö deletointia varten?
There was a problem hiding this comment.
Periaatteessa pitäisi, mutta luku- ja poisto-oikeuden pitäisi aina kulkea käsi kädessä. Oikeampi korjaus olisi nimetä lukuoikeus uudelleen.
Wnt
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dikumentaatio: https://github.com/espoon-voltti/evaka/wiki/Titania-ty%C3%B6aikaintegraatio