Pääkäyttäjä voi ajastaa tulevia luvituksia etukäteen #6339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joosakur
force-pushed
the
scheduled-acl
branch
2 times, most recently
from
9728da0 to
3734ec3
Compare
Joosakur
force-pushed
the
acl-end-dates
branch
from
75ff298 to
34e3054
Compare
Joosakur
force-pushed
the
scheduled-acl
branch
from
3734ec3 to
98e37d7
Compare
Joosakur
force-pushed
the
scheduled-acl
branch
from
98e37d7 to
1fff006
Compare
terolaakso
approved these changes
Feb 6, 2025
| @@ -214,6 +231,10 @@ class EmployeeController(private val accessControl: AccessControl) { | |||
| ) | |||
|
|
|||
| tx.deleteEmployeeDaycareRoles(id, daycareId) | |||
| if (daycareId == null) { | |||
| tx.deleteScheduledDaycareAclRows(id) | |||
| } | |||
There was a problem hiding this comment.
Pitäiskö tässä poistaa daycare-kohtainen ajastusrivi, tapauksessa jossa daycareId ei ole null?
There was a problem hiding this comment.
Luulisin että tässä tapauksessa ei. Oikeastaan toi daycareId=null keissi ois varmaan selkeempi olla oma endpointtinsa koska se on se erillinen "poista käyttäjän kaikki luvitukset" nappi, joka intuitiivisesti tarkoittaa sekä nykyisiä että tulevia.
frontend/src/employee-frontend/components/unit/tab-unit-information/UnitAccessControl.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.