Vähennetään apigw:stä tulevia turhia virhehälyjä #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason we sometimes receive GET requests to SAML login endpoints, but there's no handler for the request ends up getting proxied to evaka-service, which logs noisy errors. It's better to just redirect to the corresponding app root in apigw, because all valid auth routes are there so we know any other routes don't exist and will just lead to an error later.
These errors are noisy, and seem to nowadays happen only when some bots hammer our APIs with random requests.
- move to a separate function - call the function inside try/catch -> errors are handled instead of thrown to generic error middleware
akheron
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no GET endpoint /citizen/auth/...