Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add reverse order removed logs feed #31271

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: Add reverse order removed logs feed #31271

wants to merge 7 commits into from

Conversation

DeVikingMark
Copy link

Description

Implements the TODO in reorg function by adding a dedicated event feed for removed logs in reverse order.

This allows new integrations to receive logs in the correct order while maintaining backward compatibility with existing integrations.

Changes:

  • Add rmLogsReverseFeed event feed to BlockChain
  • Implement sending reversed logs to the new feed
  • Add SubscribeRemovedLogsReverseEvent method and update interfaces
  • Update filter system to handle the new event feed

@rjl493456442
Copy link
Member

Please fix the PR first, revert the changes in the eth/backend.go, it can't compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl

@s1na s1na Awaiting requested review from s1na

@lightclient lightclient Awaiting requested review from lightclient

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeVikingMark @rjl493456442