eth: avoid transaction pool query when annoucing transaction #31309
+62
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
reviewed
Mar 4, 2025
core/types/transaction.go
Outdated
Comment on lines
449
to
451
| if sc := blobtx.Sidecar; sc != nil { | ||
| tx.sidecarSize = rlp.ListSize(sc.encodedSize()) | ||
| } |
There was a problem hiding this comment.
I haven't looked into this PR too deeply yet, but this part strikes me as really weird, and goes against the implied semantics of the method (which one would assume doesn't mutate the instance it is called on).
There was a problem hiding this comment.
I've fixed this. The intention is to set cpy.sidecarSize not the tx.sidecarSize.
With eth/68, transaction announcement must have transaction type and size. So in announceTransactions, we need to query the transaction from transaction pool with its hash. This creates overhead in case of blob transaction which needs to load data from limbo and RLP decode. This commit tries to avoid transaction pool query by providing the transaction type and size information along with hash right from the beginning.
|
Any time we receive a remote transaction in the fetcher, we cache the encoded size (including sidecar) on the transaction object: https://github.com/ethereum/go-ethereum/blob/master/eth/fetcher/tx_fetcher.go#L365 . If a transaction originates locally, we will do this when adding it to the local pool. So afaict, this PR isn't necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With eth/68, transaction announcement must have transaction type and size. So in announceTransactions, we need to query the transaction from transaction pool with its hash. This creates overhead in case of blob transaction which needs to load data from limbo and RLP decode. This commit tries to avoid transaction pool query by providing the transaction type and size information along with hash right from the beginning.